Summary: | Web Inspector: Clicking on Clear Network Items icon throws an exception if timing popover is visible | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Nikita Vasilyev
2017-03-18 14:43:30 PDT
Created attachment 304879 [details]
Patch
Comment on attachment 304879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304879&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:430 > + let dismissPopover = () => { > + if (this.dataGrid) > + this.dataGrid._popover.dismiss(); > + }; > + > + this.dataGrid._dismissPopoverTimeout = setTimeout(dismissPopover, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout); Style: We normally inline arrow functions used in only one place: this.dataGrid._dismissPopoverTimeout = setTimeout(() => { if (this.dataGrid) this.dataGrid._popover.dismiss(); }, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout); Created attachment 304974 [details]
Patch
Comment on attachment 304974 [details] Patch Clearing flags on attachment: 304974 Committed r214199: <http://trac.webkit.org/changeset/214199> All reviewed patches have been landed. Closing bug. |