Bug 169845

Summary: TextIndicator should support a mode where selection rects are used to size the snapshot
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Hook into new flag in WK2 none

Description Wenson Hsieh 2017-03-17 22:03:53 PDT 
<rdar://problem/31127818>
Comment 1 Wenson Hsieh 2017-03-17 22:12:03 PDT 
Created attachment 304861 [details]
Patch
Comment 2 Wenson Hsieh 2017-03-17 22:28:59 PDT 
Created attachment 304863 [details]
Hook into new flag in WK2
Comment 3 Wenson Hsieh 2017-03-20 10:03:47 PDT 
Comment on attachment 304863 [details]
Hook into new flag in WK2

Thanks Beth!
Comment 4 WebKit Commit Bot 2017-03-20 10:32:52 PDT 
Comment on attachment 304863 [details]
Hook into new flag in WK2

Clearing flags on attachment: 304863

Committed r214174: <http://trac.webkit.org/changeset/214174>
Comment 5 WebKit Commit Bot 2017-03-20 10:32:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Tim Horton 2017-03-22 13:14:34 PDT 
Comment on attachment 304863 [details]
Hook into new flag in WK2

View in context: https://bugs.webkit.org/attachment.cgi?id=304863&action=review

> Source/WebCore/page/TextIndicator.h:89
> +    // Currently, this is only supported on iOS.

This is a little weird, I think, because the text rects *are* the selection rects on Mac, right?
Comment 7 Wenson Hsieh 2017-03-22 13:17:17 PDT 
(In reply to Tim Horton from comment #6)
> Comment on attachment 304863 [details]
> Hook into new flag in WK2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304863&action=review
> 
> > Source/WebCore/page/TextIndicator.h:89
> > +    // Currently, this is only supported on iOS.
> 
> This is a little weird, I think, because the text rects *are* the selection
> rects on Mac, right?

True. This is a bit confusing, since the rects used here specifically refer to those emitted by our selection rect collection heuristic on iOS. I'll make this distinction clear in a followup.