Bug 169802

Summary: Use completion handlers instead of return values for sending websocket data
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Fix GTK+ build cgarcia: review+

Alex Christensen
Reported 2017-03-16 18:15:07 PDT
Use completion handlers instead of return values for sending websocket data
Attachments
Patch (8.89 KB, patch)
2017-03-16 18:15 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.85 KB, patch)
2017-03-16 21:42 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (11.02 KB, patch)
2017-03-17 00:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Fix GTK+ build (11.32 KB, patch)
2017-03-17 01:31 PDT, Carlos Garcia Campos 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-03-16 18:15:51 PDT
Created attachment 304731 [details] Patch
Alex Christensen
Comment 2 2017-03-16 21:42:34 PDT
Created attachment 304752 [details] Patch
Alex Christensen
Comment 3 2017-03-16 22:39:40 PDT
I don't understand why GTK fails to build. Could someone look at it?
Alex Christensen
Comment 4 2017-03-17 00:18:03 PDT
Created attachment 304761 [details] Patch
Carlos Garcia Campos
Comment 5 2017-03-17 01:31:20 PDT
Created attachment 304766 [details] Fix GTK+ build Function.h needs to be included in WebSocketServerConnection.cpp
Carlos Garcia Campos
Comment 6 2017-03-17 02:46:36 PDT
Comment on attachment 304766 [details] Fix GTK+ build r=me
Alex Christensen
Comment 7 2017-03-17 08:57:36 PDT
http://trac.webkit.org/r214106
Alex Christensen
Comment 8 2017-03-17 08:57:54 PDT
Thanks Carlos!
Note You need to log in before you can comment on or make changes to this bug.