Bug 169793

Summary:

buildbot: run-webkit-tests should display test failures and run exceptions differently

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, clopez, commit-queue, lforschler

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jonathan Bedard

Reported 2017-03-16 15:30:10 PDT

Right now, failing to run LayoutTests because of a simulator or test harness bug is treated the same way a single test failure is. Simulator bugs and test harness bugs, as well as any exception thrown and not managed in run-webkit-tests should cause an exception in build-bot.

Attachments
Patch (1.83 KB, patch) 2017-03-16 15:37 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2017-03-16 15:37:49 PDT

Created attachment 304707 [details] Patch

Alexey Proskuryakov

Comment 2 2017-03-17 11:23:42 PDT

Is this happening on bots? Do you have an example link?

Jonathan Bedard

Comment 3 2017-03-17 12:35:00 PDT

(In reply to comment #2) > Is this happening on bots? Do you have an example link? Currently, the WebKit bots are in a stable state, so we are not experiencing these issues at the moment.

WebKit Commit Bot

Comment 4 2017-03-20 10:11:06 PDT

Comment on attachment 304707 [details] Patch Clearing flags on attachment: 304707 Committed r214172: <http://trac.webkit.org/changeset/214172>

WebKit Commit Bot

Comment 5 2017-03-20 10:11:12 PDT

All reviewed patches have been landed. Closing bug.

Carlos Alberto Lopez Perez

Comment 6 2017-03-23 14:45:21 PDT

Committed r214318: <http://trac.webkit.org/changeset/214318>

Note You need to log in before you can comment on or make changes to this bug.