Bug 169779

Summary: Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Matt Baker 2017-03-16 13:32:25 PDT 
DOMDebuggerManager.prototype._saveBreakpoints should be "_saveDOMBreakpoints".
Comment 1 Matt Baker 2017-03-16 13:35:34 PDT 
Created attachment 304684 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-16 14:39:41 PDT 
Comment on attachment 304684 [details]
Patch

This isn't exactly a typo, its a real bug fix. I'm actually surprised no tests cause this, I'd expect any test using addDOMBreakpoint to trigger an uncaught exception and show up in test results.
Comment 3 Matt Baker 2017-03-16 15:32:27 PDT 
Created attachment 304705 [details]
Patch
Comment 4 WebKit Commit Bot 2017-03-16 17:23:48 PDT 
Comment on attachment 304705 [details]
Patch

Clearing flags on attachment: 304705

Committed r214083: <http://trac.webkit.org/changeset/214083>
Comment 5 WebKit Commit Bot 2017-03-16 17:23:54 PDT 
All reviewed patches have been landed.  Closing bug.