Bug 169757

Summary: webktpy: Fix device regular expression for parsing simctl output
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168397    
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2017-03-16 09:02:09 PDT
The fix in <http://trac.webkit.org/changeset/213164> was insufficient. We should make the UDID portion of the regular expression more strict to ensure that an unavailable device is correctly parsed.
Attachments
Patch (3.37 KB, patch)
2017-03-16 09:06 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.59 KB, patch)
2017-03-16 09:32 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-03-16 09:06:41 PDT
Created attachment 304644 [details] Patch
Daniel Bates
Comment 2 2017-03-16 09:27:13 PDT
Comment on attachment 304644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304644&action=review > Tools/ChangeLog:7 > + Please explain the purpose of this change. Specifically, what this change is fixing as well as how it relates the fix in bug #168394.
Jonathan Bedard
Comment 3 2017-03-16 09:32:01 PDT
Created attachment 304646 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-03-16 10:12:42 PDT
Comment on attachment 304646 [details] Patch for landing Clearing flags on attachment: 304646 Committed r214046: <http://trac.webkit.org/changeset/214046>
WebKit Commit Bot
Comment 5 2017-03-16 10:12:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.