Bug 169743

Summary: [JSC] Generate TemplateObjects at linking time
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch keith_miller: review+

Yusuke Suzuki
Reported 2017-03-16 03:02:04 PDT
[JSC] Generate TemplateObjects at linking time
Attachments
Patch (16.42 KB, patch)
2017-03-16 03:06 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (18.74 KB, patch)
2017-03-16 12:30 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (18.63 KB, patch)
2017-03-16 12:34 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-03-16 03:06:27 PDT
Created attachment 304627 [details] Patch
Yusuke Suzuki
Comment 2 2017-03-16 12:30:10 PDT
Created attachment 304673 [details] Patch
Yusuke Suzuki
Comment 3 2017-03-16 12:34:41 PDT
Created attachment 304674 [details] Patch
Yusuke Suzuki
Comment 4 2017-04-04 10:35:59 PDT
Ping?
Keith Miller
Comment 5 2017-04-04 10:57:53 PDT
Comment on attachment 304674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304674&action=review r=me with a question. > Source/JavaScriptCore/bytecode/CodeBlock.cpp:932 > + scope.release(); Why do you need the manually release the scope here?
Yusuke Suzuki
Comment 6 2017-04-05 00:06:48 PDT
Comment on attachment 304674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304674&action=review >> Source/JavaScriptCore/bytecode/CodeBlock.cpp:932 >> + scope.release(); > > Why do you need the manually release the scope here? Oops, it's not neccessary. Thanks.
Yusuke Suzuki
Comment 7 2017-04-05 00:09:48 PDT
Committed r214931: <http://trac.webkit.org/changeset/214931>
Note You need to log in before you can comment on or make changes to this bug.