Bug 169721

Summary: [DFG] Don't use ArraySlice intrinsic on MIPS
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, guijemont, jbriance, keith_miller, mark.lam, msaboff, saam, ysuzuki
Priority: P2    
Version: Other   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch none

Guillaume Emont
Reported 2017-03-15 17:05:00 PDT
The ArraySlice intrinsic in DFG uses more registers than we have available on MIPS, so we have to do the same as for X86 and not use it.
Attachments
Patch (2.12 KB, patch)
2017-03-15 17:12 PDT, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2017-03-15 17:12:00 PDT
Created attachment 304584 [details] Patch The patch.
Yusuke Suzuki
Comment 2 2017-03-21 16:57:04 PDT
Comment on attachment 304584 [details] Patch r=me
Konstantin Tokarev
Comment 3 2017-03-22 00:41:35 PDT
I don't believe that MIPS, having 2x more GPRs than 32-bit ARM, cannot have ArraySlice
Yusuke Suzuki
Comment 4 2017-03-22 04:39:22 PDT
(In reply to Konstantin Tokarev from comment #3) > I don't believe that MIPS, having 2x more GPRs than 32-bit ARM, cannot have > ArraySlice I think we should disable it right now since MIPS' temporary registers listed in GPRInfo is less than ARM. If we would like to enable it, first, I think we should modify this part to increase temporary registers.
WebKit Commit Bot
Comment 5 2017-03-22 10:15:20 PDT
Comment on attachment 304584 [details] Patch Clearing flags on attachment: 304584 Committed r214253: <http://trac.webkit.org/changeset/214253>
WebKit Commit Bot
Comment 6 2017-03-22 10:15:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.