Bug 169721 - [DFG] Don't use ArraySlice intrinsic on MIPS
Summary: [DFG] Don't use ArraySlice intrinsic on MIPS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 17:05 PDT by Guillaume Emont
Modified: 2017-03-22 10:15 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2017-03-15 17:12 PDT, Guillaume Emont 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Emont 2017-03-15 17:05:00 PDT 
The ArraySlice intrinsic in DFG uses more registers than we have available on MIPS, so we have to do the same as for X86 and not use it.
Comment 1 Guillaume Emont 2017-03-15 17:12:00 PDT 
Created attachment 304584 [details]
Patch

The patch.
Comment 2 Yusuke Suzuki 2017-03-21 16:57:04 PDT 
Comment on attachment 304584 [details]
Patch

r=me
Comment 3 Konstantin Tokarev 2017-03-22 00:41:35 PDT 
I don't believe that MIPS, having 2x more GPRs than 32-bit ARM, cannot have ArraySlice
Comment 4 Yusuke Suzuki 2017-03-22 04:39:22 PDT 
(In reply to Konstantin Tokarev from comment #3)
> I don't believe that MIPS, having 2x more GPRs than 32-bit ARM, cannot have
> ArraySlice

I think we should disable it right now since MIPS' temporary registers listed in GPRInfo is less than ARM.
If we would like to enable it, first, I think we should modify this part to increase temporary registers.
Comment 5 WebKit Commit Bot 2017-03-22 10:15:20 PDT 
Comment on attachment 304584 [details]
Patch

Clearing flags on attachment: 304584

Committed r214253: <http://trac.webkit.org/changeset/214253>
Comment 6 WebKit Commit Bot 2017-03-22 10:15:23 PDT 
All reviewed patches have been landed.  Closing bug.