Bug 169702
| Summary: | Web Inspector: Refactoring: create parallel Breakpoint/BreakpointTreeElement class hierarchies | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> |
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> |
| Status: | NEW | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 169697 | ||
| Bug Blocks: | |||
Matt Baker
Due to the recent proliferation of breakpoint types (Script, DOM, XHR) and associated tree elements, it makes sense to refactor these class hierarchies to reduce code duplication. This will also make it easier to reason about breakpoints in the UI.
Breakpoint, DOMBreakpoint, and XHRBreakpoint should inherit from a common base, providing common enabled/resolved behavior. We have two options for naming the new base class:
1) GenericBreakpoint
2) Breakpoint (the existing Breakpoint class would become ScriptBreakpoint)
The second options feels more correct, since "breakpoint" is now a concept shared by multiple entities. However, it would require lots of renaming so we might want to stick with the first option.
BreakpointTreeElement, DOMTreeElement, and XHRBreakpointTreeElement should inherit from a common base, providing styles ("breakpoint", "breakpoint-generic-line-icon", etc) and common DOM/behavior such as the status button. The base class name should match the breakpoint class hierarchy.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |