Bug 169687

Summary:

Web Inspector: Add icons for SVG Image cluster path components

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, commit-queue, inspector-bugzilla-changes

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=16079

Attachments:

Description	Flags
Patch	joepeck: review+
[Image] After Patch is applied - Image	none
[Image] After Patch is applied - Source	none
Patch	none

Devin Rousso

Reported 2017-03-15 11:44:58 PDT

Attachments
Patch (4.94 KB, patch) 2017-03-15 14:36 PDT, Devin Rousso	joepeck: review+	Details Formatted Diff Diff
[Image] After Patch is applied - Image (15.37 KB, image/png) 2017-03-15 14:36 PDT, Devin Rousso	no flags	Details
[Image] After Patch is applied - Source (14.61 KB, image/png) 2017-03-15 14:37 PDT, Devin Rousso	no flags	Details
Patch (15.75 KB, patch) 2017-03-15 15:01 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-03-15 14:36:15 PDT

Created attachment 304549 [details] Patch

Devin Rousso

Comment 2 2017-03-15 14:36:54 PDT

Created attachment 304550 [details] [Image] After Patch is applied - Image

Devin Rousso

Comment 3 2017-03-15 14:37:15 PDT

Created attachment 304551 [details] [Image] After Patch is applied - Source

Joseph Pecoraro

Comment 4 2017-03-15 14:48:59 PDT

Comment on attachment 304549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304549&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + * UserInterface/Images/Image.svg: Added. We should do something for Images/gtk. Perhaps the same thing but with their box style. It should be pretty easy. > Source/WebInspectorUI/UserInterface/Images/Image.svg:7 > + <rect fill="rgb(133, 208, 163)" stroke="grey" x="4" y="6" width="6" height="6"/> > + <circle fill="rgb(191, 215, 233)" stroke="grey" cx="9.5" cy="6.5" r="3"/> I was going to suggest `gray` instead of `grey` but I guess it doesn't matter. > Source/WebInspectorUI/UserInterface/Views/PathComponentIcons.css:111 > + content: url("../Images/Events.svg"); I'd actually prefer that we duplicate the icon and name it Source.svg. That way we can change one without negatively impacting other places in Web Inspector. This goes for Images/gtk as well which doesn't have this image anyways.

Devin Rousso

Comment 5 2017-03-15 15:01:54 PDT

Created attachment 304556 [details] Patch

Timothy Hatcher

Comment 6 2017-03-15 15:10:29 PDT

Comment on attachment 304556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304556&action=review > Source/WebInspectorUI/UserInterface/Images/gtk/Image.svg:22 > + <rect fill="rgb(133, 208, 163)" stroke="grey" x="4" y="6" width="6" height="6"/> > + <circle fill="rgb(191, 215, 233)" stroke="grey" cx="9.5" cy="6.5" r="3"/> Nit: The stroke in the file icon is a darker blue and darker green, not grey.

WebKit Commit Bot

Comment 7 2017-03-15 15:29:32 PDT

Comment on attachment 304556 [details] Patch Clearing flags on attachment: 304556 Committed r214011: <http://trac.webkit.org/changeset/214011>

WebKit Commit Bot

Comment 8 2017-03-15 15:29:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.