Bug 169687 – Web Inspector: Add icons for SVG Image cluster path components

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 304549 [details]
Patch

[Devin Rousso]

Created attachment 304550 [details]
[Image] After Patch is applied - Image

[Devin Rousso]

Created attachment 304551 [details]
[Image] After Patch is applied - Source

[Joseph Pecoraro]

Comment on attachment 304549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304549&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +        * UserInterface/Images/Image.svg: Added.

We should do something for Images/gtk. Perhaps the same thing but with their box style. It should be pretty easy.

> Source/WebInspectorUI/UserInterface/Images/Image.svg:7
> +    <rect fill="rgb(133, 208, 163)" stroke="grey" x="4" y="6" width="6" height="6"/>
> +    <circle fill="rgb(191, 215, 233)" stroke="grey" cx="9.5" cy="6.5" r="3"/>

I was going to suggest `gray` instead of `grey` but I guess it doesn't matter.

> Source/WebInspectorUI/UserInterface/Views/PathComponentIcons.css:111
> +    content: url("../Images/Events.svg");

I'd actually prefer that we duplicate the icon and name it Source.svg. That way we can change one without negatively impacting other places in Web Inspector. This goes for Images/gtk as well which doesn't have this image anyways.

[Devin Rousso]

Created attachment 304556 [details]
Patch

[Timothy Hatcher]

Comment on attachment 304556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304556&action=review

> Source/WebInspectorUI/UserInterface/Images/gtk/Image.svg:22
> + <rect fill="rgb(133, 208, 163)" stroke="grey" x="4" y="6" width="6" height="6"/>
> + <circle fill="rgb(191, 215, 233)" stroke="grey" cx="9.5" cy="6.5" r="3"/>

Nit: The stroke in the file icon is a darker blue and darker green, not grey.

[WebKit Commit Bot]

Comment on attachment 304556 [details]
Patch

Clearing flags on attachment: 304556

Committed r214011: <http://trac.webkit.org/changeset/214011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.