Bug 169687 - Web Inspector: Add icons for SVG Image cluster path components
Summary: Web Inspector: Add icons for SVG Image cluster path components
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 11:44 PDT by Devin Rousso
Modified: 2017-03-15 15:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.94 KB, patch)
2017-03-15 14:36 PDT, Devin Rousso
joepeck: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied - Image (15.37 KB, image/png)
2017-03-15 14:36 PDT, Devin Rousso
no flags Details
[Image] After Patch is applied - Source (14.61 KB, image/png)
2017-03-15 14:37 PDT, Devin Rousso
no flags Details
Patch (15.75 KB, patch)
2017-03-15 15:01 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-03-15 11:44:58 PDT
.
Comment 1 Devin Rousso 2017-03-15 14:36:15 PDT
Created attachment 304549 [details]
Patch
Comment 2 Devin Rousso 2017-03-15 14:36:54 PDT
Created attachment 304550 [details]
[Image] After Patch is applied - Image
Comment 3 Devin Rousso 2017-03-15 14:37:15 PDT
Created attachment 304551 [details]
[Image] After Patch is applied - Source
Comment 4 Joseph Pecoraro 2017-03-15 14:48:59 PDT
Comment on attachment 304549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304549&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +        * UserInterface/Images/Image.svg: Added.

We should do something for Images/gtk. Perhaps the same thing but with their box style. It should be pretty easy.

> Source/WebInspectorUI/UserInterface/Images/Image.svg:7
> +    <rect fill="rgb(133, 208, 163)" stroke="grey" x="4" y="6" width="6" height="6"/>
> +    <circle fill="rgb(191, 215, 233)" stroke="grey" cx="9.5" cy="6.5" r="3"/>

I was going to suggest `gray` instead of `grey` but I guess it doesn't matter.

> Source/WebInspectorUI/UserInterface/Views/PathComponentIcons.css:111
> +    content: url("../Images/Events.svg");

I'd actually prefer that we duplicate the icon and name it Source.svg. That way we can change one without negatively impacting other places in Web Inspector. This goes for Images/gtk as well which doesn't have this image anyways.
Comment 5 Devin Rousso 2017-03-15 15:01:54 PDT
Created attachment 304556 [details]
Patch
Comment 6 Timothy Hatcher 2017-03-15 15:10:29 PDT
Comment on attachment 304556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304556&action=review

> Source/WebInspectorUI/UserInterface/Images/gtk/Image.svg:22
> + <rect fill="rgb(133, 208, 163)" stroke="grey" x="4" y="6" width="6" height="6"/>
> + <circle fill="rgb(191, 215, 233)" stroke="grey" cx="9.5" cy="6.5" r="3"/>

Nit: The stroke in the file icon is a darker blue and darker green, not grey.
Comment 7 WebKit Commit Bot 2017-03-15 15:29:32 PDT
Comment on attachment 304556 [details]
Patch

Clearing flags on attachment: 304556

Committed r214011: <http://trac.webkit.org/changeset/214011>
Comment 8 WebKit Commit Bot 2017-03-15 15:29:36 PDT
All reviewed patches have been landed.  Closing bug.