Bug 169668

Summary:

[Modern Media Controls] Always use six digits to display time when overall media duration is an hour or more

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Antoine Quint 2017-03-15 02:25:30 PDT

We currently use extra margins around time labels that may eventually show a duration an hour or more so that when that happens, we don't resize everything. But this creates some extra space which is not elegant. We should instead be using six digits at all times when we know the media duration is an hour or more.

Comment 1 Radar WebKit Bug Importer 2017-03-15 02:25:52 PDT

<rdar://problem/31059699>

Comment 2 Antoine Quint 2017-03-15 02:46:01 PDT

Created attachment 304492 [details]
Patch

Comment 3 WebKit Commit Bot 2017-03-15 05:42:41 PDT

Comment on attachment 304492 [details]
Patch

Clearing flags on attachment: 304492

Committed r213980: <http://trac.webkit.org/changeset/213980>

Comment 4 WebKit Commit Bot 2017-03-15 05:42:44 PDT

All reviewed patches have been landed.  Closing bug.