Bug 169667

Summary:

URL: protocol setter needs to be more restrictive around file

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

DOM

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, rbuis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Anne van Kesteren

Reported 2017-03-15 01:35:09 PDT

See new tests added in https://github.com/w3c/web-platform-tests/pull/5112 and standard changes at https://github.com/whatwg/url/pull/269.

Attachments
Patch (14.26 KB, patch) 2019-10-06 09:16 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (14.26 KB, patch) 2019-10-06 12:13 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (14.17 KB, patch) 2019-10-19 11:42 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (9.23 KB, patch) 2019-10-21 00:32 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (8.20 KB, patch) 2019-10-21 02:23 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (9.47 KB, patch) 2019-10-21 08:43 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Patch (8.21 KB, patch) 2019-10-22 00:09 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2019-10-06 09:16:51 PDT

Created attachment 380298 [details] Patch

Rob Buis

Comment 2 2019-10-06 12:13:54 PDT

Created attachment 380302 [details] Patch

Rob Buis

Comment 3 2019-10-19 11:42:47 PDT

Created attachment 381374 [details] Patch

Rob Buis

Comment 4 2019-10-21 00:32:02 PDT

Created attachment 381406 [details] Patch

Rob Buis

Comment 5 2019-10-21 02:23:50 PDT

Created attachment 381410 [details] Patch

Rob Buis

Comment 6 2019-10-21 08:43:20 PDT

Created attachment 381413 [details] Patch

Alex Christensen

Comment 7 2019-10-21 13:35:00 PDT

Comment on attachment 381413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=381413&action=review > Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:154 > + fprintf(stderr, "InjectedBundle::overrideBoolPreferenceForTestRunner\n"); This looks like debug code that should not be committed. > Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:265 > + fprintf(stderr, "Set CSSTypedOMEnabled\n"); ditto

Rob Buis

Comment 8 2019-10-22 00:09:05 PDT

Created attachment 381516 [details] Patch

WebKit Commit Bot

Comment 9 2019-10-22 01:20:41 PDT

Comment on attachment 381516 [details] Patch Clearing flags on attachment: 381516 Committed r251422: <https://trac.webkit.org/changeset/251422>

WebKit Commit Bot

Comment 10 2019-10-22 01:20:43 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2019-10-22 01:21:18 PDT

<rdar://problem/56492506>

Darin Adler

Comment 12 2019-10-22 09:57:28 PDT

Seems a little strange to add this restriction at the URL::setProtocol level; I would have expected it to be a level higher.

Note You need to log in before you can comment on or make changes to this bug.