Bug 169667

Summary: URL: protocol setter needs to be more restrictive around file
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, rbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Anne van Kesteren 2017-03-15 01:35:09 PDT 
See new tests added in https://github.com/w3c/web-platform-tests/pull/5112 and standard changes at https://github.com/whatwg/url/pull/269.
Comment 1 Rob Buis 2019-10-06 09:16:51 PDT 
Created attachment 380298 [details]
Patch
Comment 2 Rob Buis 2019-10-06 12:13:54 PDT 
Created attachment 380302 [details]
Patch
Comment 3 Rob Buis 2019-10-19 11:42:47 PDT 
Created attachment 381374 [details]
Patch
Comment 4 Rob Buis 2019-10-21 00:32:02 PDT 
Created attachment 381406 [details]
Patch
Comment 5 Rob Buis 2019-10-21 02:23:50 PDT 
Created attachment 381410 [details]
Patch
Comment 6 Rob Buis 2019-10-21 08:43:20 PDT 
Created attachment 381413 [details]
Patch
Comment 7 Alex Christensen 2019-10-21 13:35:00 PDT 
Comment on attachment 381413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381413&action=review

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:154
> +    fprintf(stderr, "InjectedBundle::overrideBoolPreferenceForTestRunner\n");

This looks like debug code that should not be committed.

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:265
> +        fprintf(stderr, "Set CSSTypedOMEnabled\n");

ditto
Comment 8 Rob Buis 2019-10-22 00:09:05 PDT 
Created attachment 381516 [details]
Patch
Comment 9 WebKit Commit Bot 2019-10-22 01:20:41 PDT 
Comment on attachment 381516 [details]
Patch

Clearing flags on attachment: 381516

Committed r251422: <https://trac.webkit.org/changeset/251422>
Comment 10 WebKit Commit Bot 2019-10-22 01:20:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-10-22 01:21:18 PDT 
<rdar://problem/56492506>
Comment 12 Darin Adler 2019-10-22 09:57:28 PDT 
Seems a little strange to add this restriction at the URL::setProtocol level; I would have expected it to be a level higher.