Bug 169665

Summary: [TexMap] Add missing class member initializations
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, commit-queue, kondapallykalyan, luiz, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104114    
Attachments:
Description Flags
Patch mcatanzaro: review+

Zan Dobersek
Reported 2017-03-15 01:31:17 PDT
[TexMap] Add missing class member initializations
Attachments
Patch (3.95 KB, patch)
2017-03-15 01:33 PDT, Zan Dobersek 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-03-15 01:33:11 PDT
Created attachment 304489 [details] Patch
Michael Catanzaro
Comment 2 2017-03-15 08:50:58 PDT
Comment on attachment 304489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304489&action=review > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:62 > + double m_lastUsedTime { 0 }; So I know it doesn't matter... but that's an int. I like to write 0.0. > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:235 > + double m_lastAnimationStartTime { 0 }; Ditto.
Zan Dobersek
Comment 3 2017-03-15 11:02:12 PDT
Committed r213989: <http://trac.webkit.org/changeset/213989>
Konstantin Tokarev
Comment 4 2017-04-03 00:56:34 PDT
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 304489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304489&action=review > > > Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:62 > > + double m_lastUsedTime { 0 }; > > So I know it doesn't matter... but that's an int. I like to write 0.0. Coding style says we should write "0" https://webkit.org/code-style-guidelines/#floating-point-literals > > > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:235 > > + double m_lastAnimationStartTime { 0 }; > > Ditto.
Note You need to log in before you can comment on or make changes to this bug.