Bug 169656

Summary: FTL should support global and eval code
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
possible patch ggaren: review+

Description Filip Pizlo 2017-03-14 21:10:35 PDT 
Patch forthcoiming.
Comment 1 Filip Pizlo 2017-03-14 21:11:36 PDT 
Created attachment 304468 [details]
possible patch

STill testing it
Comment 2 WebKit Commit Bot 2017-03-15 15:52:16 PDT 
Attachment 304468 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLink.cpp:137:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/ftl/FTLLink.cpp:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2017-03-15 18:01:17 PDT 
Comment on attachment 304468 [details]
possible patch

r=me
Comment 4 Saam Barati 2017-03-15 20:11:39 PDT 
Comment on attachment 304468 [details]
possible patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304468&action=review

LGTM too

> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:-397
> -    jit.load32(CCallHelpers::payloadFor(CallFrameSlot::argumentCount), GPRInfo::regT2);

Was all this code just unneeded?
Comment 5 Filip Pizlo 2017-03-16 08:52:58 PDT 
(In reply to comment #4)
> Comment on attachment 304468 [details]
> possible patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304468&action=review
> 
> LGTM too
> 
> > Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:-397
> > -    jit.load32(CCallHelpers::payloadFor(CallFrameSlot::argumentCount), GPRInfo::regT2);
> 
> Was all this code just unneeded?

Yeah!  Crazy!
Comment 6 Filip Pizlo 2017-03-16 14:19:47 PDT 
Landed in https://trac.webkit.org/changeset/214069