Bug 169648

Summary:

Make server tests return a promise instead of manually calling done

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dewei_zhu, joepeck, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup the tests	none
Cleaned up some more	cdumez: review+

Ryosuke Niwa

Reported 2017-03-14 17:21:49 PDT

Right now, some old mocha tests in server-tests are manually calling done. Return a promise instead since the latest mocha.js supports that, and manually calling done turned out be error prone.

Attachments
Cleanup the tests (179.34 KB, patch) 2017-03-14 17:26 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Cleaned up some more (186.52 KB, patch) 2017-03-14 19:38 PDT, Ryosuke Niwa	cdumez: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-03-14 17:26:37 PDT

Created attachment 304449 [details] Cleanup the tests

Ryosuke Niwa

Comment 2 2017-03-14 19:38:58 PDT

Created attachment 304465 [details] Cleaned up some more

Chris Dumez

Comment 3 2017-03-14 19:48:08 PDT

Comment on attachment 304465 [details] Cleaned up some more rs=me

Ryosuke Niwa

Comment 4 2017-03-14 20:18:57 PDT

Thanks!

Ryosuke Niwa

Comment 5 2017-03-14 20:19:05 PDT

Committed r213969: <http://trac.webkit.org/changeset/213969>

Note You need to log in before you can comment on or make changes to this bug.