Summary: | Add support for RTCPeerConnection.onicecandidateerror event | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||||||||
Component: | WebKit Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, annulen, aperez, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, kondapallykalyan, magomez, philipj, ryuan.choi, sergio, solmaks, tommyw, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 173118 | ||||||||||||||
Bug Blocks: | 169662 | ||||||||||||||
Attachments: |
|
Description
Jon Lee
2017-03-14 16:51:36 PDT
Created attachment 414574 [details]
Patch
Created attachment 414582 [details]
Patch
Created attachment 414605 [details]
Patch
Comment on attachment 414605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414605&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357 > + if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) { It seems strange to me to be using path for host-like things here, but that's how it works. > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46 > + uint16_t errorCode; May as well add { 0 } to prevent use of uninitialized memory. > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67 > + uint16_t m_errorCode; ditto Thanks for the review. (In reply to Alex Christensen from comment #4) > Comment on attachment 414605 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414605&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357 > > + if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) { > > It seems strange to me to be using path for host-like things here, but > that's how it works. Right, though the good thing is that we do not start thinking this URL has an origin. > > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46 > > + uint16_t errorCode; > > May as well add { 0 } to prevent use of uninitialized memory. > > > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67 > > + uint16_t m_errorCode; > > ditto OK Created attachment 414657 [details]
Patch for landing
ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!. Created attachment 414662 [details]
Patch for landing
Committed r270101: <https://trac.webkit.org/changeset/270101> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414662 [details]. *** Bug 199207 has been marked as a duplicate of this bug. *** |