Bug 169644 – Add support for RTCPeerConnection.onicecandidateerror event

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jon Lee]

Update RTCPeerConnection IDL

[youenn fablet]

Created attachment 414574 [details]
Patch

[youenn fablet]

Created attachment 414582 [details]
Patch

[youenn fablet]

Created attachment 414605 [details]
Patch

[Alex Christensen]

Comment on attachment 414605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414605&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357
> +                if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) {

It seems strange to me to be using path for host-like things here, but that's how it works.

> Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46
> +        uint16_t errorCode;

May as well add { 0 } to prevent use of uninitialized memory.

> Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67
> +    uint16_t m_errorCode;

ditto

[youenn fablet]

Thanks for the review.

(In reply to Alex Christensen from comment #4)
> Comment on attachment 414605 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414605&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:357
> > +                if (url.path().endsWithIgnoringASCIICase(".local") || !portAllowed(url)) {
> 
> It seems strange to me to be using path for host-like things here, but
> that's how it works.

Right, though the good thing is that we do not start thinking this URL has an origin.

> > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:46
> > +        uint16_t errorCode;
> 
> May as well add { 0 } to prevent use of uninitialized memory.
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h:67
> > +    uint16_t m_errorCode;
> 
> ditto

OK

[youenn fablet]

Created attachment 414657 [details]
Patch for landing

[EWS]

ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.

[youenn fablet]

Created attachment 414662 [details]
Patch for landing

[EWS]

Committed r270101: <https://trac.webkit.org/changeset/270101>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414662 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71621717>

[Brent Fulgham]

*** Bug 199207 has been marked as a duplicate of this bug. ***