Bug 169643

Summary: Compiled content extensions should include the JSON source
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit2Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch
none
Patch ggaren: review+

Alex Christensen
Reported 2017-03-14 16:31:32 PDT
This way we can do things like validation of compiled binaries and automatic migrations from old versions.
Attachments
patch (28.40 KB, patch)
2017-03-14 16:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.48 KB, patch)
2017-03-14 17:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (29.47 KB, patch)
2017-03-14 17:31 PDT, Alex Christensen 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-03-14 16:37:20 PDT
Created attachment 304441 [details] patch
WebKit Commit Bot
Comment 2 2017-03-14 16:39:13 PDT
Attachment 304441 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2017-03-14 17:17:58 PDT
Created attachment 304448 [details] Patch
Alex Christensen
Comment 4 2017-03-14 17:31:30 PDT
Created attachment 304450 [details] Patch
Geoffrey Garen
Comment 5 2017-03-15 10:17:50 PDT
Comment on attachment 304450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304450&action=review r=me > Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm:38 > + switch (error.value()) { I think it's better to cast error.value() to API::ContentExtensionStore::Error instead of casting API::ContentExtensionStore::Error to int. That way, the switch can enforce checking for all enumerated values at compile time.
Alex Christensen
Comment 6 2017-03-15 10:59:24 PDT
http://trac.webkit.org/r213988
Note You need to log in before you can comment on or make changes to this bug.