Bug 169631

Summary:

Simple line layout: Extend webkit-hyphenate-limit-lines to cover subsequent words.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, koivisto, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	none

Description zalan 2017-03-14 14:43:24 PDT

Current this property on forced on the current word. 
like:
respon-
sibili-
ties
but not across multiple words on different lines like
foobar foo-
bar fo foo-
bar

Comment 1 zalan 2017-03-14 14:49:59 PDT

Created attachment 304427 [details]
Patch

Comment 2 zalan 2017-03-15 18:26:09 PDT

Created attachment 304591 [details]
Patch

Comment 3 Build Bot 2017-03-15 19:30:35 PDT

Comment on attachment 304591 [details]
Patch

Attachment 304591 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3334827

New failing tests:
fast/text/hyphenate-limit-lines.html

Comment 4 Build Bot 2017-03-15 19:30:40 PDT

Created attachment 304596 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Build Bot 2017-03-15 19:33:28 PDT

Comment on attachment 304591 [details]
Patch

Attachment 304591 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3334832

New failing tests:
fast/text/hyphenate-limit-lines.html

Comment 6 Build Bot 2017-03-15 19:33:31 PDT

Created attachment 304597 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 7 Build Bot 2017-03-15 19:42:02 PDT

Comment on attachment 304591 [details]
Patch

Attachment 304591 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3334838

New failing tests:
fast/text/hyphenate-limit-lines.html

Comment 8 Build Bot 2017-03-15 19:42:05 PDT

Created attachment 304599 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 9 zalan 2017-03-16 14:33:05 PDT

Created attachment 304693 [details]
Patch

Comment 10 WebKit Commit Bot 2017-03-16 15:14:39 PDT

Comment on attachment 304693 [details]
Patch

Clearing flags on attachment: 304693

Committed r214072: <http://trac.webkit.org/changeset/214072>

Comment 11 WebKit Commit Bot 2017-03-16 15:14:53 PDT

All reviewed patches have been landed.  Closing bug.