Bug 169604

Summary: Fix uninitialized public members in WebProcess
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: WebKit2Assignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, clopez, commit-queue, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104114    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tomas Popela 2017-03-14 07:46:50 PDT 
Found by Coverity scan.
Comment 1 Tomas Popela 2017-03-14 07:48:40 PDT 
Created attachment 304379 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-14 07:50:39 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2017-03-14 08:09:28 PDT 
Comment on attachment 304379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304379&action=review

Looks good, but the changelog entry is broken!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:171
> +    GtkWidget* inspectorView { nullptr};

Missing a space here.
Comment 4 David Kilzer (:ddkilzer) 2017-03-15 05:51:56 PDT 
Comment on attachment 304379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304379&action=review

> Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:102
> +    HTTPCookieAcceptPolicy cookieAcceptPolicy { 0 };

This would read better as an enum value than an int.
Comment 5 Tomas Popela 2017-03-15 06:52:51 PDT 
Created attachment 304496 [details]
Patch

Correct the patch (after I previously had some problems with webkit-patch).
Comment 6 Michael Catanzaro 2017-03-15 08:34:00 PDT 
(In reply to comment #5)
> Created attachment 304496 [details]
> Patch
> 
> Correct the patch (after I previously had some problems with webkit-patch).

Did you want to mark it for review?
Comment 7 Alex Christensen 2017-03-16 09:22:00 PDT 
Comment on attachment 304496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304496&action=review

r=me

> Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:103
> +    bool ignoreTLSErrors { true };

You might want to make the default value of this to be false to be safer unless someone explicitly says they want to ignore tls errors.
Comment 8 Michael Catanzaro 2017-03-16 20:22:15 PDT 
Yeah, please make that false... if it breaks something, let's specify it when constructed instead.

I assume that it's already explicitly specified everywhere anyway...?
Comment 9 Tomas Popela 2017-03-17 00:19:23 PDT 
Sorry guys, but this patch was intended for bug 169598 as this bug is about WebProcess.

(In reply to comment #7)
> > Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:103
> > +    bool ignoreTLSErrors { true };
> 
> You might want to make the default value of this to be false to be safer
> unless someone explicitly says they want to ignore tls errors.

Yes, this makes sense, thanks!
Comment 10 Tomas Popela 2017-03-17 00:23:27 PDT 
Created attachment 304762 [details]
Patch

Finally a patch for the WebProcess..
Comment 11 Tomas Popela 2017-03-17 06:13:10 PDT 
Comment on attachment 304762 [details]
Patch

Clearing flags on attachment: 304762

Committed r214104: <http://trac.webkit.org/changeset/214104>
Comment 12 Tomas Popela 2017-03-17 06:13:27 PDT 
All reviewed patches have been landed.  Closing bug.