Bug 169601

Summary:

Fix uninitialized public members in Webkit2/Shared

Product:

WebKit

Reporter:

Tomas Popela <tpopela>

Component:

WebKit2

Assignee:

Tomas Popela <tpopela>

Status:

NEW

Severity:

Normal

CC:

buildbot, cdumez, cgarcia, clopez, commit-queue, mcatanzaro, mjs, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

104114

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	mjs: review-

Tomas Popela

Reported 2017-03-14 07:03:16 PDT

Found by Coverity scan.

Attachments
Patch (15.55 KB, patch) 2017-03-14 07:06 PDT, Tomas Popela	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.48 MB, application/zip) 2017-03-14 08:07 PDT, Build Bot	no flags	Details
Patch (8.34 KB, patch) 2017-03-17 10:36 PDT, Tomas Popela	mjs: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tomas Popela

Comment 1 2017-03-14 07:06:39 PDT

Created attachment 304375 [details] Patch

Build Bot

Comment 2 2017-03-14 08:07:35 PDT

Comment on attachment 304375 [details] Patch Attachment 304375 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3320602 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2017-03-14 08:07:39 PDT

Created attachment 304382 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Tomas Popela

Comment 4 2017-03-17 10:36:22 PDT

Created attachment 304793 [details] Patch Correct the patch (after I previously had some problems with webkit-patch).

Michael Catanzaro

Comment 5 2017-03-22 11:56:38 PDT

Ping owners

Alexey Proskuryakov

Comment 6 2017-03-22 13:12:01 PDT

I'm still very much unsure if this is desirable, as it makes it harder to find uninitialized variable issues with UBSan.

Maciej Stachowiak

Comment 7 2020-05-30 18:08:42 PDT

Comment on attachment 304793 [details] Patch Where these fields found to ever actually be used uninitialized, or is this a "just in case"? I think on the whole it's better to initialize these. Unfortunately, this patch no longer applies, so r- for current version.

Michael Catanzaro

Comment 8 2020-05-31 06:48:25 PDT

I'm really skeptical that leaving variables initially uninitialized at runtime is a good way to "debug" failure to initialize them to some specific value later, given this makes the code significantly less robust. In this case, the goal was to resolve various warnings from Coverity. WebKit would probably benefit significantly from an effort to get our Coverity results into better shape. Sadly, that requires significant time and effort....

Note You need to log in before you can comment on or make changes to this bug.