Bug 169589

Summary: Web Inspector: Remove unnecessary assert for Number.percentageString
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2017-03-13 22:38:00 PDT
It is valid to have a fraction greater than 1, as well as for that fraction to be converted to a percentage point.
Attachments
Patch (1.33 KB, patch)
2017-03-13 22:38 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-03-13 22:38:49 PDT
Created attachment 304355 [details] Patch
Matt Baker
Comment 2 2017-03-14 00:59:28 PDT
Comment on attachment 304355 [details] Patch r=me. Did this come up? Are we showing values < 0% or > 100%?
WebKit Commit Bot
Comment 3 2017-03-14 01:28:10 PDT
Comment on attachment 304355 [details] Patch Clearing flags on attachment: 304355 Committed r213890: <http://trac.webkit.org/changeset/213890>
WebKit Commit Bot
Comment 4 2017-03-14 01:28:14 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5 2017-03-14 10:56:44 PDT
Comment on attachment 304355 [details] Patch I think the intent here was originally we only ever expected positive numbers. Was there a case where we could get negative numbers?
Note You need to log in before you can comment on or make changes to this bug.