Bug 169584 – Web Inspector: RTL: add support for Memory timeline

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

.

[Devin Rousso]

Created attachment 304347 [details]
Patch

[Devin Rousso]

Created attachment 304348 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 304347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304347&action=review

r=me. CSS changes look good. I did notice that the size text for each category seems to be backwards compared to the legends. If this uses a localized string, then it should be OK - the localizers can switch 'Highest: %s' to '%s :Highest'.

> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:123
> +            markerElement.style.setProperty(WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL ? "right" : "left", `${xScale(memoryPressureEvent.timestamp)}px`);

Please extract the property to a local variable so this is easier to read (especially, say, in a search result).

[Devin Rousso]

Created attachment 304410 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 304410 [details]
Patch

Clearing flags on attachment: 304410

Committed r213942: <http://trac.webkit.org/changeset/213942>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.