Bug 169583

Summary: Web Inspector: RTL: add support for TimelineOverview sidebar and container layout
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 168287    
Attachments:
Description Flags
Patch
bburg: review+
[Image] After Patch is applied
none
Patch none

Description Devin Rousso 2017-03-13 21:21:59 PDT
.
Comment 1 Devin Rousso 2017-03-13 21:32:59 PDT
Created attachment 304345 [details]
Patch
Comment 2 Devin Rousso 2017-03-13 21:33:21 PDT
Created attachment 304346 [details]
[Image] After Patch is applied
Comment 3 BJ Burg 2017-03-13 22:14:57 PDT
Comment on attachment 304345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304345&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31
> +body[dir=ltr] .timeline-overview > .tree-outline.timelines {

Can this use :matches() ?

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:37
> +body[dir=rtl] .timeline-overview > .tree-outline.timelines {

Ditto

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167
> +    bottom: 0;

Does the ruler still look right in LTR? Or was this property unnecessary?
Comment 4 Devin Rousso 2017-03-13 22:28:20 PDT
Comment on attachment 304345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304345&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31
>> +body[dir=ltr] .timeline-overview > .tree-outline.timelines {
> 
> Can this use :matches() ?

Good catch!

>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167
>> +    bottom: 0;
> 
> Does the ruler still look right in LTR? Or was this property unnecessary?

I did this so that I don't have to add a reset for the other property when only setting one or the other in LTR/RTL (see lines 42 and 46).  This way, I can also merge the rules together to make a single selector.
Comment 5 Devin Rousso 2017-03-14 11:46:47 PDT
Created attachment 304407 [details]
Patch
Comment 6 WebKit Commit Bot 2017-03-14 12:07:32 PDT
Comment on attachment 304407 [details]
Patch

Clearing flags on attachment: 304407

Committed r213924: <http://trac.webkit.org/changeset/213924>
Comment 7 WebKit Commit Bot 2017-03-14 12:07:35 PDT
All reviewed patches have been landed.  Closing bug.