Summary: | Web Inspector: RTL: add support for TimelineOverview sidebar and container layout | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 168287 | ||||||||||
Attachments: |
|
Description
Devin Rousso
2017-03-13 21:21:59 PDT
Created attachment 304345 [details]
Patch
Created attachment 304346 [details]
[Image] After Patch is applied
Comment on attachment 304345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304345&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31 > +body[dir=ltr] .timeline-overview > .tree-outline.timelines { Can this use :matches() ? > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:37 > +body[dir=rtl] .timeline-overview > .tree-outline.timelines { Ditto > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167 > + bottom: 0; Does the ruler still look right in LTR? Or was this property unnecessary? Comment on attachment 304345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304345&action=review >> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31 >> +body[dir=ltr] .timeline-overview > .tree-outline.timelines { > > Can this use :matches() ? Good catch! >> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167 >> + bottom: 0; > > Does the ruler still look right in LTR? Or was this property unnecessary? I did this so that I don't have to add a reset for the other property when only setting one or the other in LTR/RTL (see lines 42 and 46). This way, I can also merge the rules together to make a single selector. Created attachment 304407 [details]
Patch
Comment on attachment 304407 [details] Patch Clearing flags on attachment: 304407 Committed r213924: <http://trac.webkit.org/changeset/213924> All reviewed patches have been landed. Closing bug. |