Bug 169555

Summary: [GTK] Remove dead code from previous autotools build in build-jsc
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, commit-queue, ggaren, mark.lam, ossy, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2017-03-13 08:09:28 PDT
When the autotools build for WebKitGTK+ was removed in r166239 the function buildGtkProject() for building WebKitGTK+ with autootols was removed from Tools/Scripts/webkitdirs.pm. However one call to it was left in build-jsc. However this never get executed because the "if (isCMakeBuild()) {}" path is executed before it and it always exits.
Attachments
Patch (1.24 KB, patch)
2017-03-13 08:14 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2017-03-13 08:14:19 PDT
Created attachment 304256 [details] Patch
WebKit Commit Bot
Comment 2 2017-03-13 08:46:03 PDT
Comment on attachment 304256 [details] Patch Clearing flags on attachment: 304256 Committed r213845: <http://trac.webkit.org/changeset/213845>
WebKit Commit Bot
Comment 3 2017-03-13 08:46:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.