Bug 169539

Summary: WebGPU remote layer hosting
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 167952    
Attachments:
Description Flags
Patch
none
Patch jonlee: review+

Jon Lee
Reported 2017-03-13 00:26:40 PDT
WebGPU remote layer hosting
Attachments
Patch (10.66 KB, patch)
2017-03-13 00:44 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (10.57 KB, patch)
2017-03-13 00:45 PDT, Dean Jackson 		jonlee: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-03-13 00:27:03 PDT
<rdar://problem/31005380>
Radar WebKit Bug Importer
Comment 2 2017-03-13 00:27:22 PDT
<rdar://problem/31005384>
Dean Jackson
Comment 3 2017-03-13 00:44:14 PDT
Created attachment 304235 [details] Patch
Dean Jackson
Comment 4 2017-03-13 00:45:06 PDT
Created attachment 304236 [details] Patch
Jon Lee
Comment 5 2017-03-13 00:49:34 PDT
Comment on attachment 304236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304236&action=review > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:897 > + case PlatformCALayer::LayerTypeWebGLLayer: WebGPULayer
Jon Lee
Comment 6 2017-03-13 00:50:55 PDT
Comment on attachment 304236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304236&action=review r+ with WebGL -> WebGPU fix in RemoteLayerTreeTransaction.mm. > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:302 > +#endif ick.
Jon Lee
Comment 7 2017-03-13 00:55:37 PDT
Committed r213786.
Dean Jackson
Comment 8 2017-03-13 00:57:54 PDT
Committed r213786: <http://trac.webkit.org/changeset/213786>
Simon Fraser (smfr)
Comment 9 2017-03-13 08:15:05 PDT
Comment on attachment 304236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304236&action=review > Source/WebCore/platform/graphics/ca/PlatformCALayer.h:77 > + LayerTypeWebGPULayer, Does it actually need to be its own layer type, or can we just rename LayerTypeWebGLLayer to be a bit more generic?
Dean Jackson
Comment 10 2017-03-14 14:28:42 PDT
(In reply to comment #9) > Comment on attachment 304236 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=304236&action=review > > > Source/WebCore/platform/graphics/ca/PlatformCALayer.h:77 > > + LayerTypeWebGPULayer, > > Does it actually need to be its own layer type, or can we just rename > LayerTypeWebGLLayer to be a bit more generic? Done in 169628
Note You need to log in before you can comment on or make changes to this bug.