Bug 169526

Summary: [GTK] File choosers should run as modal by default if possible
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-03-12 11:29:30 PDT
Right now file chooser dialogs are never run as modal by default. It would be desirable to try to obtain the GtkWindow where the GtkWebView is embedded, set it as parent of the dialogs, and enable running them as modal.
Attachments
Patch (2.29 KB, patch)
2017-03-12 12:35 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-03-12 12:35:50 PDT
Created attachment 304203 [details] Patch
WebKit Commit Bot
Comment 2 2017-03-12 12:37:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2017-03-12 12:38:05 PDT
Comment on attachment 304203 [details] Patch Although possibly applications might not want this behavior, this definitely ought to be the default behavior to avoid unexpected bugs in applications.
WebKit Commit Bot
Comment 4 2017-03-12 13:19:07 PDT
Comment on attachment 304203 [details] Patch Clearing flags on attachment: 304203 Committed r213772: <http://trac.webkit.org/changeset/213772>
WebKit Commit Bot
Comment 5 2017-03-12 13:19:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.