Bug 169520

Summary: Structure::willStoreValueSlow needs to keep the property table alive until the end
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
msaboff: review+
patch for landing none

Filip Pizlo
Reported 2017-03-11 22:06:13 PST
Patch forthcoming.
Attachments
the patch (3.29 KB, patch)
2017-03-11 22:09 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
patch for landing (3.30 KB, patch)
2017-03-12 10:00 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-03-11 22:09:10 PST
Created attachment 304186 [details] the patch
WebKit Commit Bot
Comment 2 2017-03-11 22:12:23 PST
Attachment 304186 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/HeapCell.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 3 2017-03-11 22:55:12 PST
Comment on attachment 304186 [details] the patch r=me You may want to add that you're keeping this alive for the conservative scan.
Filip Pizlo
Comment 4 2017-03-12 10:00:35 PDT
Created attachment 304193 [details] patch for landing Checking windows ews
WebKit Commit Bot
Comment 5 2017-03-12 10:03:16 PDT
Attachment 304193 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/HeapCell.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2017-03-12 15:58:44 PDT
Landed in r213773.
Note You need to log in before you can comment on or make changes to this bug.