Summary: | FTL should not flush strict arguments unless it really needs to | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 169561, 169562 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Filip Pizlo
2017-03-11 21:18:22 PST
Created attachment 304184 [details]
the patch
Comment on attachment 304184 [details] the patch Attachment 304184 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/3296400 New failing tests: mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-dfg-eager-no-cjit-validate-phases stress/super-property-access.js.ftl-eager-no-cjit mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-no-ftl stress/super-property-access.js.ftl-eager mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-llint mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-ftl-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla (In reply to comment #2) > Comment on attachment 304184 [details] > the patch > > Attachment 304184 [details] did not pass jsc-ews (mac): > Output: http://webkit-queues.webkit.org/results/3296400 > > New failing tests: > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-dfg-eager-no-cjit-validate- > phases > stress/super-property-access.js.ftl-eager-no-cjit > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-no-ftl > stress/super-property-access.js.ftl-eager > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-llint > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-ftl-eager-no-cjit-validate- > phases > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla Hahahahaha! DST is happening! Comment on attachment 304184 [details]
the patch
r=me
Re-opened since this is blocked by bug 169562 This was rolled out in r213860: <http://trac.webkit.org/changeset/213860>. |