Bug 169519

Summary: FTL should not flush strict arguments unless it really needs to
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, sbarati
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 169561, 169562    
Bug Blocks:    
Attachments:
Description Flags
the patch mark.lam: review+, buildbot: commit-queue-

Description Filip Pizlo 2017-03-11 21:18:22 PST
We use flushing of arguments for a lot of different things. One of them is sloppy arguments reflection. We can easily teach the FTL not to do that for strict mode.
Comment 1 Filip Pizlo 2017-03-11 21:22:35 PST
Created attachment 304184 [details]
the patch
Comment 2 Build Bot 2017-03-11 22:00:57 PST
Comment on attachment 304184 [details]
the patch

Attachment 304184 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/3296400

New failing tests:
mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-dfg-eager-no-cjit-validate-phases
stress/super-property-access.js.ftl-eager-no-cjit
mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline
mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-no-ftl
stress/super-property-access.js.ftl-eager
mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-llint
mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-ftl-eager-no-cjit-validate-phases
mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla
Comment 3 Filip Pizlo 2017-03-11 22:10:21 PST
(In reply to comment #2)
> Comment on attachment 304184 [details]
> the patch
> 
> Attachment 304184 [details] did not pass jsc-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3296400
> 
> New failing tests:
> mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-dfg-eager-no-cjit-validate-
> phases
> stress/super-property-access.js.ftl-eager-no-cjit
> mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline
> mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-no-ftl
> stress/super-property-access.js.ftl-eager
> mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-llint
> mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-ftl-eager-no-cjit-validate-
> phases
> mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla

Hahahahaha! DST is happening!
Comment 4 Mark Lam 2017-03-13 10:56:10 PDT
Comment on attachment 304184 [details]
the patch

r=me
Comment 5 Filip Pizlo 2017-03-13 11:00:46 PDT
Landed in r213856
Comment 6 WebKit Commit Bot 2017-03-13 12:34:52 PDT
Re-opened since this is blocked by bug 169562
Comment 7 Mark Lam 2017-03-13 12:37:52 PDT
This was rolled out in r213860: <http://trac.webkit.org/changeset/213860>.
Comment 8 Filip Pizlo 2017-03-13 15:53:28 PDT
Relanded with fixes in r213876