Bug 169518 – Variation fonts: Make sure that feature detection and preprocessor macros are right

• Component: Text
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Do a pass over the previously-implemented things and make sure that feature detection is right.

[Myles C. Maxfield]

Created attachment 305393 [details]
Test

[Myles C. Maxfield]

Created attachment 305397 [details]
Patch

[Build Bot]

Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3410704

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-stretch-parse.html
fast/css/font-calculated-value.html
css1/font_properties/font.html
css2.1/t1508-c527-font-08-b.html
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html

[Build Bot]

Created attachment 305403 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3410707

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-stretch-parse.html
fast/css/font-calculated-value.html
css1/font_properties/font.html
css2.1/t1508-c527-font-08-b.html
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html

[Build Bot]

Created attachment 305404 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3410714

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-stretch-parse.html
fast/css/font-calculated-value.html
css1/font_properties/font.html
css2.1/t1508-c527-font-08-b.html
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html

[Build Bot]

Created attachment 305405 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3411315

New failing tests:
fast/scrolling/ios/touch-scroll-pointer-events-none.html
fast/text/font-variations-feature-detection.html
fast/history/page-cache-createObjectURL-using-open-panel.html

[Build Bot]

Created attachment 305414 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305397 [details]
Patch

Attachment 305397 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3411792

New failing tests:
fast/text/font-variations-feature-detection.html

[Build Bot]

Created attachment 305417 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 305569 [details]
Patch

[Build Bot]

Comment on attachment 305569 [details]
Patch

Attachment 305569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3425769

New failing tests:
fast/text/font-weight-parse.html
fast/text/font-style-parse.html
fast/text/font-stretch-parse.html
fast/text/font-selection-font-loading-api-parse.html
fast/text/font-selection-font-face-parse.html

[Build Bot]

Created attachment 305577 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305569 [details]
Patch

Attachment 305569 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3425967

New failing tests:
fast/css/getComputedStyle/computed-style-font-family.html

[Build Bot]

Created attachment 305582 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 305649 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 305649 [details]
Patch

Rejecting attachment 305649 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 305649, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
arse-expected.txt
patching file LayoutTests/platform/mac-elcapitan/fast/text/font-stretch-parse-expected.txt
patching file LayoutTests/platform/mac-elcapitan/fast/text/font-style-parse-expected.txt
patching file LayoutTests/platform/mac-elcapitan/fast/text/font-weight-parse-expected.txt
patching file LayoutTests/platform/mac/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3431257

[Myles C. Maxfield]

Created attachment 305712 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 305715 [details]
Patch for committing

[Build Bot]

Comment on attachment 305715 [details]
Patch for committing

Attachment 305715 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3432513

New failing tests:
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html

[Build Bot]

Created attachment 305718 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305715 [details]
Patch for committing

Attachment 305715 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3432520

New failing tests:
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html

[Build Bot]

Created attachment 305719 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 305715 [details]
Patch for committing

Attachment 305715 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3432519

New failing tests:
fast/text/font-style-parse.html
fast/text/font-selection-font-loading-api-parse.html

[Build Bot]

Created attachment 305721 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Committed r214546: <http://trac.webkit.org/changeset/214546>

[Myles C. Maxfield]

Committed r214552: <http://trac.webkit.org/changeset/214552>

[Myles C. Maxfield]

Committed r214555: <http://trac.webkit.org/changeset/214555>