Bug 169491 – Make RealtimeMediaSource::type an enum class

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

It is an enum right now.

[youenn fablet]

Created attachment 304097 [details]
Patch

[WebKit Commit Bot]

Attachment 304097 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/MediaEndpoint.cpp:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 304296 [details]
Patch

[WebKit Commit Bot]

Attachment 304296 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/MediaEndpoint.cpp:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 304319 [details]
Patch

[WebKit Commit Bot]

Attachment 304319 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/MediaEndpoint.cpp:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 304319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304319&action=review

> LayoutTests/imported/w3c/resources/TestRepositories:18
> -        "revision": "06c6c52e05e05483d3c844168a417ee27a554eb7",
> +        "revision": "728e02d",

Looks unrelated.

[youenn fablet]

Thanks for the review.

(In reply to comment #7)
> Comment on attachment 304319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304319&action=review
> 
> > LayoutTests/imported/w3c/resources/TestRepositories:18
> > -        "revision": "06c6c52e05e05483d3c844168a417ee27a554eb7",
> > +        "revision": "728e02d",
> 
> Looks unrelated.

Done

[youenn fablet]

Created attachment 304339 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 304339 [details]
Patch for landing

Rejecting attachment 304339 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 304339, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
8489619c008ee491a5dc237 596bd5ec8ffbeb7ba1c8c60c78b619f7a231a4f1 M	Source
Current branch master is up to date.
# of revisions changed  
before:
  

after:
 fe674ffa6c3a7b25e45f50bef44c726e9077ae10 
 If you are attempting to commit  merges, try running:
	 git rebase --interactive --preserve-merges  refs/remotes/origin/master 
Before dcommitting

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/3317086

[WebKit Commit Bot]

Comment on attachment 304339 [details]
Patch for landing

Rejecting attachment 304339 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 304339, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
atform/mock/MockRealtimeMediaSource.cpp
Hunk #1 FAILED at 84.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/mock/MockRealtimeMediaSource.cpp.rej
patching file Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
Hunk #1 FAILED at 66.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3320638