Bug 169490

Summary: [Win] Re-export a few symbols needed for backwards compatibility
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, bshafiei, commit-queue, ossy, pvollan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 169545    
Attachments:
Description Flags
Patch bfulgham: review+

Brent Fulgham
Reported 2017-03-10 16:00:17 PST
Re-introduce an old hack needed to support very old software.
Attachments
Patch (11.82 KB, patch)
2017-03-10 16:02 PST, Brent Fulgham 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2017-03-10 16:02:07 PST
Created attachment 304089 [details] Patch
Brent Fulgham
Comment 2 2017-03-10 16:02:35 PST
Comment on attachment 304089 [details] Patch Patch was previously reviewed by Dean Jackson and landed on a branch. Merging this back to mainline.
Brent Fulgham
Comment 3 2017-03-10 16:02:52 PST
Uploading to Bugzilla to perform EWS run.
WebKit Commit Bot
Comment 4 2017-03-10 16:11:16 PST
Attachment 304089 [details] did not pass style-queue: ERROR: Source/WebKit/win/WebKitDLL.cpp:272: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit/win/WebKitDLL.cpp:287: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 5 2017-03-10 16:59:13 PST
Committed in r213737: <https://trac.webkit.org/changeset/213737>.
Csaba Osztrogonác
Comment 6 2017-03-11 13:44:05 PST
(In reply to comment #3) > Uploading to Bugzilla to perform EWS run. And you landed with red EWS and broke the Apple Windows build ...
Brent Fulgham
Comment 7 2017-03-13 13:46:51 PDT
Build fix to handle new warning-as-error setting: Committed r213847: <http://trac.webkit.org/changeset/213847>
Per Arne Vollan
Comment 8 2017-03-13 14:54:18 PDT
(In reply to comment #7) > Build fix to handle new warning-as-error setting: > > Committed r213847: <http://trac.webkit.org/changeset/213847> I believe we need this as well: <http://trac.webkit.org/changeset/213846>.
Note You need to log in before you can comment on or make changes to this bug.