Bug 169488

Summary: Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2017-03-10 15:33:38 PST
Summary: Only show "Break on..." menu if backend supports DOM breakpoints. Need to add a check to DOMTreeElement.
Attachments
Patch (2.72 KB, patch)
2017-03-10 15:35 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-03-10 15:35:24 PST
Created attachment 304086 [details] Patch
Joseph Pecoraro
Comment 2 2017-03-10 17:15:05 PST
Comment on attachment 304086 [details] Patch r=me
Devin Rousso
Comment 3 2017-03-10 17:15:58 PST
Comment on attachment 304086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304086&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js:47 > + console.assert(WebInspector.domDebuggerManager.supported); I feel like it would be much simpler and less mistake prone in future changes if we added the support check inside this function instead of at the call sites. Considering the fact that multiple separators in a row in a context menu are collapsed, I think this may be the better (and possibly more centralized) approach.
WebKit Commit Bot
Comment 4 2017-03-10 17:56:11 PST
Comment on attachment 304086 [details] Patch Clearing flags on attachment: 304086 Committed r213744: <http://trac.webkit.org/changeset/213744>
WebKit Commit Bot
Comment 5 2017-03-10 17:56:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.