Bug 169477

Summary: Simple line layout: Check how many orphans needed on the current page before breaking.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2017-03-10 11:20:45 PST
SSIA.
Attachments
Patch (6.37 KB, patch)
2017-03-10 11:23 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.61 KB, patch)
2017-03-10 11:44 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.81 KB, patch)
2017-03-10 12:27 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2017-03-10 11:23:17 PST
Created attachment 304057 [details] Patch
Antti Koivisto
Comment 2 2017-03-10 11:39:54 PST
Comment on attachment 304057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304057&action=review > Source/WebCore/rendering/SimpleLineLayoutPagination.cpp:73 > + int windowsOnTheNextPage = lineCount - breakCandidate; I think you want "widows" not "windows".
alan
Comment 3 2017-03-10 11:44:44 PST
Created attachment 304058 [details] Patch
alan
Comment 4 2017-03-10 12:27:03 PST
Created attachment 304063 [details] Patch
WebKit Commit Bot
Comment 5 2017-03-10 16:33:22 PST
Comment on attachment 304063 [details] Patch Clearing flags on attachment: 304063 Committed r213733: <http://trac.webkit.org/changeset/213733>
WebKit Commit Bot
Comment 6 2017-03-10 16:33:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.