Bug 169477 - Simple line layout: Check how many orphans needed on the current page before breaking.
Summary: Simple line layout: Check how many orphans needed on the current page before ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-10 11:20 PST by zalan
Modified: 2017-03-10 16:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.37 KB, patch)
2017-03-10 11:23 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.61 KB, patch)
2017-03-10 11:44 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.81 KB, patch)
2017-03-10 12:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-03-10 11:20:45 PST 
SSIA.
Comment 1 zalan 2017-03-10 11:23:17 PST 
Created attachment 304057 [details]
Patch
Comment 2 Antti Koivisto 2017-03-10 11:39:54 PST 
Comment on attachment 304057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304057&action=review

> Source/WebCore/rendering/SimpleLineLayoutPagination.cpp:73
> +    int windowsOnTheNextPage = lineCount - breakCandidate;

I think you want "widows" not "windows".
Comment 3 zalan 2017-03-10 11:44:44 PST 
Created attachment 304058 [details]
Patch
Comment 4 zalan 2017-03-10 12:27:03 PST 
Created attachment 304063 [details]
Patch
Comment 5 WebKit Commit Bot 2017-03-10 16:33:22 PST 
Comment on attachment 304063 [details]
Patch

Clearing flags on attachment: 304063

Committed r213733: <http://trac.webkit.org/changeset/213733>
Comment 6 WebKit Commit Bot 2017-03-10 16:33:26 PST 
All reviewed patches have been landed.  Closing bug.