Bug 169472

Summary:

Move libwebrtc backend to using tracks

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alex, commit-queue, eric.carlson

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

169491

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none
Patch	none

youenn fablet

Reported 2017-03-10 09:16:13 PST

We should move to the newer libwebrtc API

Attachments
Patch (34.13 KB, patch) 2017-03-10 09:26 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (34.08 KB, patch) 2017-03-10 10:09 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (34.10 KB, patch) 2017-03-10 13:56 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (20.24 KB, patch) 2017-03-10 16:18 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-03-10 09:26:47 PST

Created attachment 304047 [details] Patch

WebKit Commit Bot

Comment 2 2017-03-10 09:27:37 PST

Attachment 304047 [details] did not pass style-queue: ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:209: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:215: media_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:217: stream_ids is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 3 2017-03-10 10:09:27 PST

Created attachment 304052 [details] Patch

WebKit Commit Bot

Comment 4 2017-03-10 10:11:17 PST

Attachment 304052 [details] did not pass style-queue: ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:209: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:215: media_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:217: stream_ids is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 5 2017-03-10 10:49:18 PST

Comment on attachment 304052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304052&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:177 > + if (source.type() == RealtimeMediaSource::Audio) { I think Type should be made an enum class instead of an enum and this should be made a switch statement. Right now we are assuming that if a media source is not audio it is video, when there are three values in RealtimeMediaSource::Type. That might be a good assumption, but I think switching on enums is good practice.

youenn fablet

Comment 6 2017-03-10 13:56:46 PST

Created attachment 304071 [details] Patch for landing

youenn fablet

Comment 7 2017-03-10 16:18:51 PST

Created attachment 304092 [details] Patch

WebKit Commit Bot

Comment 8 2017-03-10 16:46:48 PST

Comment on attachment 304071 [details] Patch for landing Clearing flags on attachment: 304071 Committed r213736: <http://trac.webkit.org/changeset/213736>

WebKit Commit Bot

Comment 9 2017-03-10 16:46:53 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.