Bug 169459

Summary: [QuickLook] Add WKNavigationDelegate SPI to notify when a password is requested
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dino, fpizlo, mark.lam, thorton, webkit-bug-importer, yianzhou2
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2017-03-09 19:25:12 PST
[QuickLook] Add WKNavigationDelegate SPI to notify when a password is requested
Attachments
Patch (264.04 KB, patch)
2017-03-09 19:29 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-03-09 19:25:47 PST
rdar://problem/30621913
Andy Estes
Comment 2 2017-03-09 19:29:41 PST
Created attachment 304022 [details] Patch
Alex Christensen
Comment 3 2017-03-09 19:33:02 PST
Comment on attachment 304022 [details] Patch How does one respond to such a notification?
Andy Estes
Comment 4 2017-03-09 20:22:01 PST
(In reply to comment #3) > Comment on attachment 304022 [details] > Patch > > How does one respond to such a notification? One doesn't. WebKit handles the UI for password entry. This tells the client that a navigation requires a password from the user to proceed; it's not meant to delegate the password UI itself to the client.
Andy Estes
Comment 5 2017-03-09 22:32:00 PST
More specifically, in some cases the client will show a spinner UI on top of the web view until a navigation finishes. But if the document is password-protected then the navigation won't finish until the user enters the password, which they can't do because the spinner UI is obscuring the password UI. This delegate method lets the client hide the spinner at the right time.
Alex Christensen
Comment 6 2017-03-10 10:51:27 PST
Comment on attachment 304022 [details] Patch The client ought to do the password UI, but if that's the way quick look works then this is what we have to do right now.
WebKit Commit Bot
Comment 7 2017-03-10 12:07:07 PST
Comment on attachment 304022 [details] Patch Clearing flags on attachment: 304022 Committed r213725: <http://trac.webkit.org/changeset/213725>
WebKit Commit Bot
Comment 8 2017-03-10 12:07:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.