Bug 169453

Summary:

Update font-style's implementation in the font selection algorithm

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dino, jonlee, mmaxfield, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

162815

Attachments:

Description	Flags
Needs tests	none
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch	simon.fraser: review+

Description Myles C. Maxfield 2017-03-09 16:04:04 PST

https://github.com/w3c/csswg-drafts/commit/d93fbf496e170fa94dc8b32fb62958ad2cf57842

We need to spend more time figuring out how to treat italic and oblique the same (or just stop trying to treat them the same and implement them correctly separately)

Comment 1 Myles C. Maxfield 2017-05-22 15:44:21 PDT

Created attachment 310938 [details]
Needs tests

Comment 2 Myles C. Maxfield 2017-05-22 16:35:54 PDT

Created attachment 310952 [details]
Patch

Comment 3 Build Bot 2017-05-22 17:34:15 PDT

Comment on attachment 310952 [details]
Patch

Attachment 310952 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3796974

New failing tests:
fast/text/font-style-parse.html

Comment 4 Build Bot 2017-05-22 17:34:16 PDT

Created attachment 310961 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 5 Myles C. Maxfield 2017-05-22 17:39:16 PDT

Created attachment 310963 [details]
Patch

Comment 6 Radar WebKit Bug Importer 2017-05-22 17:41:51 PDT

<rdar://problem/32341177>

Comment 7 Simon Fraser (smfr) 2017-05-22 17:45:42 PDT

Comment on attachment 310963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310963&action=review

> Source/WebCore/css/FontFace.cpp:293
> +    auto minimum = ComputedStyleExtractor::fontStyleFromStyleValue(style.minimum, true);
> +    auto maximum = ComputedStyleExtractor::fontStyleFromStyleValue(style.maximum, true);

Would read better with an enum argument. Enum could mention italic/oblique which would make this all easier to follow.

Comment 8 Myles C. Maxfield 2017-05-23 00:37:52 PDT

Committed r217272: <http://trac.webkit.org/changeset/217272>