Bug 169453

Summary: Update font-style's implementation in the font selection algorithm
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dino, jonlee, mmaxfield, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 162815    
Attachments:
Description Flags
Needs tests
none
Patch
none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
none
Patch simon.fraser: review+

Myles C. Maxfield
Reported 2017-03-09 16:04:04 PST
https://github.com/w3c/csswg-drafts/commit/d93fbf496e170fa94dc8b32fb62958ad2cf57842 We need to spend more time figuring out how to treat italic and oblique the same (or just stop trying to treat them the same and implement them correctly separately)
Attachments
Needs tests (20.82 KB, patch)
2017-05-22 15:44 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (36.15 KB, patch)
2017-05-22 16:35 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.28 MB, application/zip)
2017-05-22 17:34 PDT, Build Bot 		no flags
Details
Patch (40.34 KB, patch)
2017-05-22 17:39 PDT, Myles C. Maxfield 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-05-22 15:44:21 PDT
Created attachment 310938 [details] Needs tests
Myles C. Maxfield
Comment 2 2017-05-22 16:35:54 PDT
Created attachment 310952 [details] Patch
Build Bot
Comment 3 2017-05-22 17:34:15 PDT
Comment on attachment 310952 [details] Patch Attachment 310952 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3796974 New failing tests: fast/text/font-style-parse.html
Build Bot
Comment 4 2017-05-22 17:34:16 PDT
Created attachment 310961 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Myles C. Maxfield
Comment 5 2017-05-22 17:39:16 PDT
Created attachment 310963 [details] Patch
Radar WebKit Bug Importer
Comment 6 2017-05-22 17:41:51 PDT
<rdar://problem/32341177>
Simon Fraser (smfr)
Comment 7 2017-05-22 17:45:42 PDT
Comment on attachment 310963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310963&action=review > Source/WebCore/css/FontFace.cpp:293 > + auto minimum = ComputedStyleExtractor::fontStyleFromStyleValue(style.minimum, true); > + auto maximum = ComputedStyleExtractor::fontStyleFromStyleValue(style.maximum, true); Would read better with an enum argument. Enum could mention italic/oblique which would make this all easier to follow.
Myles C. Maxfield
Comment 8 2017-05-23 00:37:52 PDT
Committed r217272: <http://trac.webkit.org/changeset/217272>
Note You need to log in before you can comment on or make changes to this bug.