Bug 169443

Summary: Refactoring some HeapVerifier code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 161752    
Attachments:
Description Flags
proposed patch. fpizlo: review+

Mark Lam
Reported 2017-03-09 14:15:38 PST
Renamed LiveObjectData to CellProfile. Renamed LiveObjectList to CellList. Moved CellProfile.*, CellList.*, and HeapVerifier.* from the heap folder to the tools folder. Updated the HeapVerifier to handle JSCells instead of just JSObjects. This is in preparation for subsequent patches to fix up the HeapVerifier for service again.
Attachments
proposed patch. (67.64 KB, patch)
2017-03-09 14:19 PST, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-03-09 14:19:57 PST
Created attachment 303993 [details] proposed patch.
Filip Pizlo
Comment 2 2017-03-09 14:25:56 PST
Comment on attachment 303993 [details] proposed patch. seems sensible
Mark Lam
Comment 3 2017-03-09 14:39:50 PST
Thanks for the review. Landed in r213675: <http://trac.webkit.org/r213675>.
Note You need to log in before you can comment on or make changes to this bug.