Bug 169437

Summary: WebAssembly: Enable fast memory for WK2
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue, ggaren, mark.lam, mitz, msaboff, saam, sam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2017-03-09 13:19:14 PST
WebAssembly: Enable fast memory for WK2
Attachments
Patch (3.98 KB, patch)
2017-03-09 13:20 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2017-03-09 14:04 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.08 KB, patch)
2017-03-09 14:17 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-03-09 13:20:34 PST
Created attachment 303973 [details] Patch
Saam Barati
Comment 2 2017-03-09 13:44:50 PST
Comment on attachment 303973 [details] Patch I'll let folks familiar with WK2 give the thumbs up here.
Keith Miller
Comment 3 2017-03-09 14:04:28 PST
Created attachment 303984 [details] Patch
Tim Horton
Comment 4 2017-03-09 14:08:05 PST
Comment on attachment 303984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303984&action=review > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:154 > +#if ENABLE(WEBASSEMBLY) > + JSC::Wasm::enableFastMemory(); > +#endif Also possible you want to put this in WebProcess::initializeWebProcess if it is not a Cocoa-only feature. Either way, r=me.
Keith Miller
Comment 5 2017-03-09 14:14:52 PST
Comment on attachment 303984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303984&action=review >> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:154 >> +#endif > > Also possible you want to put this in WebProcess::initializeWebProcess if it is not a Cocoa-only feature. Either way, r=me. Ah, good call. Changed.
Keith Miller
Comment 6 2017-03-09 14:17:05 PST
Created attachment 303991 [details] Patch for landing
WebKit Commit Bot
Comment 7 2017-03-09 16:57:12 PST
Comment on attachment 303991 [details] Patch for landing Clearing flags on attachment: 303991 Committed r213692: <http://trac.webkit.org/changeset/213692>
WebKit Commit Bot
Comment 8 2017-03-09 16:57:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.