Bug 169394

Summary: Add new delegate methods
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Anders Carlsson
Reported 2017-03-08 16:52:07 PST
Add new delegate methods
Attachments
Patch (22.20 KB, patch)
2017-03-08 16:53 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (22.12 KB, patch)
2017-03-09 09:40 PST, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2017-03-08 16:53:19 PST
Created attachment 303865 [details] Patch
WebKit Commit Bot
Comment 2 2017-03-08 16:56:07 PST
Attachment 303865 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:59: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:534: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2017-03-09 09:40:19 PST
Created attachment 303927 [details] Patch
WebKit Commit Bot
Comment 4 2017-03-09 09:41:16 PST
Attachment 303927 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:59: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2017-03-09 10:33:33 PST
Committed r213647: <http://trac.webkit.org/changeset/213647>
Note You need to log in before you can comment on or make changes to this bug.