Bug 169394 - Add new delegate methods
Summary: Add new delegate methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-08 16:52 PST by Anders Carlsson
Modified: 2017-03-09 10:33 PST (History)
1 user (show)

See Also:

Attachments
Patch (22.20 KB, patch)
2017-03-08 16:53 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (22.12 KB, patch)
2017-03-09 09:40 PST, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2017-03-08 16:52:07 PST 
Add new delegate methods
Comment 1 Anders Carlsson 2017-03-08 16:53:19 PST 
Created attachment 303865 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-08 16:56:07 PST 
Attachment 303865 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:59:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:534:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 5 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2017-03-09 09:40:19 PST 
Created attachment 303927 [details]
Patch
Comment 4 WebKit Commit Bot 2017-03-09 09:41:16 PST 
Attachment 303927 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:59:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Carlsson 2017-03-09 10:33:33 PST 
Committed r213647: <http://trac.webkit.org/changeset/213647>