Summary: | Implement stroke-color CSS property. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||
Component: | WebCore Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, hyatt, jonlee, koivisto, simon.fraser, thorton, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2017-03-08 05:18:30 PST
Created attachment 303809 [details]
Patch
Created attachment 303953 [details]
Patch
Per, is this ready to be reviewed? I think we need the same kind of tests for checking the fallback behavior as you did for stroke-width. (In reply to comment #3) > Per, is this ready to be reviewed? > I think we need the same kind of tests for checking the fallback behavior as > you did for stroke-width. Thanks! I will add a fallback test. I think the patch needs a little more work before it is ready to be reviewed :) I will make the patch ready for review soon :) Created attachment 305966 [details]
Patch
Perhaps it would be better to just define stroke-color as an alias of -webkit-text-stroke-color (or vice versa)? (In reply to Per Arne Vollan from comment #7) > Perhaps it would be better to just define stroke-color as an alias of > -webkit-text-stroke-color (or vice versa)? Both color and width should be treated the same. I'm ok with this approach for now. Comment on attachment 305966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305966&action=review > Source/WebCore/css/CSSProperties.json:3056 > + }, I think this needs to be adjusted per 170643. > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:337 > + && visitedLinkStrokeColor == o.visitedLinkStrokeColor We need tests that include :visited links. Created attachment 306817 [details]
Patch
(In reply to Jon Lee from comment #9) > Comment on attachment 305966 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305966&action=review > > > Source/WebCore/css/CSSProperties.json:3056 > > + }, > > I think this needs to be adjusted per 170643. > > > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:337 > > + && visitedLinkStrokeColor == o.visitedLinkStrokeColor > > We need tests that include :visited links. Thanks for reviewing! I have added a new test. Comment on attachment 306817 [details]
Patch
Per, could we add tests or extend existing tests to check getComputedStyle results for all of the CSS properties you've added, particularly wrt visited links?
Comment on attachment 306817 [details] Patch Clearing flags on attachment: 306817 Committed r215261: <http://trac.webkit.org/changeset/215261> All reviewed patches have been landed. Closing bug. (In reply to Jon Lee from comment #12) > Comment on attachment 306817 [details] > Patch > > Per, could we add tests or extend existing tests to check getComputedStyle > results for all of the CSS properties you've added, particularly wrt visited > links? Yes, I will look into that in a separate patch. Thanks for reviewing! |