Bug 169350

Summary: REGRESSION (r212998): Web Inspector: DetailsSections with options have broken layout
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Watch Expressions section
none
[Image] Pause Reason section
none
Patch none

Matt Baker
Reported 2017-03-08 02:49:38 PST
Summary: DetailsSections with options have broken layout. The following details panel sections are affected: - Computed Styles (show all label) - Pause Reason (goto arrow) - Watch Expressions (toolbar) - Visual Styles sidebar (?) And soon: - XHR Breakpoints (add button) Regressed in http://trac.webkit.org/changeset/212998.
Attachments
[Image] Watch Expressions section (41.58 KB, image/png)
2017-03-08 02:58 PST, Matt Baker 		no flags
Details
[Image] Pause Reason section (59.21 KB, image/png)
2017-03-08 02:59 PST, Matt Baker 		no flags
Details
Patch (2.64 KB, patch)
2017-03-08 03:21 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-03-08 02:58:48 PST
Created attachment 303804 [details] [Image] Watch Expressions section
Matt Baker
Comment 2 2017-03-08 02:59:22 PST
Created attachment 303805 [details] [Image] Pause Reason section
Matt Baker
Comment 3 2017-03-08 03:00:13 PST
Computed Styles section wasn't affected after all, and works as expected.
Matt Baker
Comment 4 2017-03-08 03:21:05 PST
Created attachment 303807 [details] Patch
Blaze Burg
Comment 5 2017-03-08 16:57:32 PST
Comment on attachment 303807 [details] Patch rs=me, oops!
WebKit Commit Bot
Comment 6 2017-03-08 17:24:44 PST
Comment on attachment 303807 [details] Patch Clearing flags on attachment: 303807 Committed r213610: <http://trac.webkit.org/changeset/213610>
WebKit Commit Bot
Comment 7 2017-03-08 17:24:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-03-23 09:36:50 PDT
<rdar://problem/31221132>
Note You need to log in before you can comment on or make changes to this bug.