Bug 169350

Summary: REGRESSION (r212998): Web Inspector: DetailsSections with options have broken layout
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Watch Expressions section
none
[Image] Pause Reason section
none
Patch none

Description Matt Baker 2017-03-08 02:49:38 PST 
Summary:
DetailsSections with options have broken layout. The following details panel sections are affected:

- Computed Styles (show all label)
- Pause Reason (goto arrow)
- Watch Expressions (toolbar)
- Visual Styles sidebar (?)

And soon:
- XHR Breakpoints (add button)

Regressed in http://trac.webkit.org/changeset/212998.
Comment 1 Matt Baker 2017-03-08 02:58:48 PST 
Created attachment 303804 [details]
[Image] Watch Expressions section
Comment 2 Matt Baker 2017-03-08 02:59:22 PST 
Created attachment 303805 [details]
[Image] Pause Reason section
Comment 3 Matt Baker 2017-03-08 03:00:13 PST 
Computed Styles section wasn't affected after all, and works as expected.
Comment 4 Matt Baker 2017-03-08 03:21:05 PST 
Created attachment 303807 [details]
Patch
Comment 5 BJ Burg 2017-03-08 16:57:32 PST 
Comment on attachment 303807 [details]
Patch

rs=me, oops!
Comment 6 WebKit Commit Bot 2017-03-08 17:24:44 PST 
Comment on attachment 303807 [details]
Patch

Clearing flags on attachment: 303807

Committed r213610: <http://trac.webkit.org/changeset/213610>
Comment 7 WebKit Commit Bot 2017-03-08 17:24:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-03-23 09:36:50 PDT 
<rdar://problem/31221132>