Bug 169342

Summary: WebKit should not export dyld install name hints on watchOS and tvOS
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, andersca, commit-queue, mitz, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Description Alexey Proskuryakov 2017-03-07 22:18:56 PST 
They are iOS only. Sadly, our PLATFORM macros are incorrect (we define IOS for these platforms too).
Comment 1 Alexey Proskuryakov 2017-03-07 22:21:09 PST 
Created attachment 303784 [details]
proposed fix
Comment 2 mitz 2017-03-07 23:03:53 PST 
Comment on attachment 303784 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=303784&action=review

> Source/WebKit2/Shared/API/Cocoa/WebKit.m:28
> +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

I think this is a case where we may gain an extra bit of robustness by checking for PLATFORM(IOS) && TARGET_OS_IOS instead (even if the latter is not available as a WTF macro). But this is fine too.
Comment 3 WebKit Commit Bot 2017-03-07 23:52:16 PST 
Comment on attachment 303784 [details]
proposed fix

Clearing flags on attachment: 303784

Committed r213569: <http://trac.webkit.org/changeset/213569>
Comment 4 WebKit Commit Bot 2017-03-07 23:52:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2017-08-17 07:21:03 PDT 
rdar://problem/20163340