Bug 169330

Summary: JSC EWS repeat the log message thrice about patch not being relevant
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, glenn, lforschler, webkit
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2017-03-07 17:53:59 PST
When JSC EWS finds that the patch is not relevant, it repeats the log message 3 times about patch not being relevant. e.g.: https://webkit-queues.webkit.org/results/3262572 https://webkit-queues.webkit.org/results/3262491 https://webkit-queues.webkit.org/results/3262439 Checking relevance of patch This patch does not have relevant changes. This patch does not have relevant changes. This patch does not have relevant changes.
Attachments
Patch (1.39 KB, patch)
2017-03-09 12:09 PST, Srinivasan Vijayaraghavan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Srinivasan Vijayaraghavan
Comment 1 2017-03-09 12:08:02 PST
Some of these are log messages, and the unit tests rely on testing emitted logs. Will change one of the log levels to debug.
Srinivasan Vijayaraghavan
Comment 2 2017-03-09 12:09:33 PST
Created attachment 303945 [details] Patch
Aakash Jain
Comment 3 2017-03-09 12:12:50 PST
Looks fine to me. Assuming it does solve the issue properly in your local testing.
Chris Dumez
Comment 4 2017-03-09 12:45:45 PST
Comment on attachment 303945 [details] Patch rs=me
WebKit Commit Bot
Comment 5 2017-03-09 13:13:44 PST
Comment on attachment 303945 [details] Patch Clearing flags on attachment: 303945 Committed r213658: <http://trac.webkit.org/changeset/213658>
WebKit Commit Bot
Comment 6 2017-03-09 13:13:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.