Bug 169302

Summary: webkitpy: Remove obsolete port name
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, darin, dewei_zhu, fred.wang, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 169083    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2017-03-07 13:32:46 PST
Currently, EWS sends 'ios' as the port name to run-webkit-tests. A work-around has been implemented in factory.py so that this value maps to 'ios-device.' EWS should be changed to pass in 'ios-device' and the workaround removed.
Attachments
Patch (1.23 KB, patch)
2017-03-09 12:56 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.29 KB, patch)
2017-03-21 13:48 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (774.91 KB, application/zip)
2017-03-22 01:52 PDT, Build Bot 		no flags
Details
Patch (1.29 KB, patch)
2018-02-28 09:01 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2018-03-01 09:05 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2021-11-01 13:48 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-03-09 11:46:49 PST
<rdar://problem/30953024>
Jonathan Bedard
Comment 2 2017-03-09 12:56:05 PST
Created attachment 303959 [details] Patch
Jonathan Bedard
Comment 3 2017-03-21 13:48:50 PDT
Created attachment 305025 [details] Patch
Build Bot
Comment 4 2017-03-22 01:52:23 PDT
Comment on attachment 305025 [details] Patch Attachment 305025 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3381462 New failing tests: fast/media/mq-prefers-reduced-motion.html
Build Bot
Comment 5 2017-03-22 01:52:25 PDT
Created attachment 305087 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Frédéric Wang (:fredw)
Comment 6 2018-02-28 07:37:06 PST
@Jonathan: What's the status of this? It seemed the test failure was unrelated.
Jonathan Bedard
Comment 7 2018-02-28 09:01:13 PST
Created attachment 334745 [details] Patch
Jonathan Bedard
Comment 8 2018-02-28 09:02:07 PST
(In reply to Frédéric Wang (:fredw) from comment #6) > @Jonathan: What's the status of this? It seemed the test failure was > unrelated. I forgot about it. Sending it back through EWS to make sure the patch isn't stale.
Jonathan Bedard
Comment 9 2018-03-01 09:05:12 PST
Created attachment 334819 [details] Patch
Darin Adler
Comment 10 2018-09-24 18:50:20 PDT
The code change looks fine, but I don’t understand why the title of this bug talks about "should send the correct port". Isn’t this bug just a cleanup, with no change in behavior?
Jonathan Bedard
Comment 11 2018-09-27 08:24:47 PDT
(In reply to Darin Adler from comment #10) > The code change looks fine, but I don’t understand why the title of this bug > talks about "should send the correct port". Isn’t this bug just a cleanup, > with no change in behavior? Yes, this is bug is just cleanup. Previously, we used the string 'ios' to indicate the iOSPort (used for managing building and testing of iOS devices, as opposed to iOS simulated devices). I change this so that the string 'ios-device' maps to the iOSPort. This mapping was left in because some of our EWS code still used the string 'ios' instead of 'ios-device'
Darin Adler
Comment 12 2018-09-27 09:35:38 PDT
So lets set the title on this bug accordingly.
Alex Christensen
Comment 13 2021-11-01 12:02:16 PDT
Comment on attachment 334819 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Jonathan Bedard
Comment 14 2021-11-01 13:48:03 PDT
Created attachment 443008 [details] Patch
EWS
Comment 15 2021-11-01 14:24:31 PDT
Committed r285131 (243770@main): <https://commits.webkit.org/243770@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443008 [details].
Note You need to log in before you can comment on or make changes to this bug.