Bug 169234

Summary: clean up invalid domains in contributors.json
Product: WebKit Reporter: Lucas Forschler <lforschler>
Component: Tools / TestsAssignee: Lucas Forschler <lforschler>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
remove torchmobile.com.cn email accounts. ap: review+, ap: commit-queue-

Lucas Forschler
Reported 2017-03-06 16:04:46 PST
I've been informed that torchmobile.com.cn is an unregistered domain. These email addresses will bounce. Clean them up.
Attachments
remove torchmobile.com.cn email accounts. (2.28 KB, patch)
2017-03-06 16:06 PST, Lucas Forschler 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lucas Forschler
Comment 1 2017-03-06 16:06:27 PST
Created attachment 303578 [details] remove torchmobile.com.cn email accounts.
WebKit Commit Bot
Comment 2 2017-03-06 16:08:41 PST
Attachment 303578 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Lucas Forschler
Comment 3 2017-03-06 16:13:13 PST
Looks like I'll need to land this manually. Please do not CQ+ it.
Lucas Forschler
Comment 4 2017-03-06 16:20:47 PST
Committed revision 213479.
Konstantin Tokarev
Comment 5 2018-01-11 06:57:09 PST
I thought one of purposes of contributors.json was identifying person from e-mail adress of the commit. In our history there are 187 commits with commiter email e-mail matching torchmobile.com.cn
Note You need to log in before you can comment on or make changes to this bug.