Bug 169225

Summary: Add WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit2Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen, mitz, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ap: review-, ap: commit-queue-
Updated patch
thorton: review+
Updated patch none

Aakash Jain
Reported 2017-03-06 15:15:39 PST
So as to match headers exactly with the binary and make TAPI happy.
Attachments
Proposed patch (1.79 KB, patch)
2017-03-06 15:19 PST, Aakash Jain 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
Updated patch (1.80 KB, patch)
2017-03-06 17:17 PST, Aakash Jain 		thorton: review+
DetailsFormatted DiffDiff
Updated patch (1.78 KB, patch)
2017-03-06 19:42 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-03-06 15:19:20 PST
Created attachment 303567 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2017-03-06 15:26:22 PST
Comment on attachment 303567 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=303567&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKLinkIconParameters.h:38 > +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) I don't think that this one is accurate. I don't see _WKLinkIconParameters in any shipping WebKit version.
Aakash Jain
Comment 3 2017-03-06 17:17:04 PST
Created attachment 303589 [details] Updated patch
Tim Horton
Comment 4 2017-03-06 17:20:57 PST
Comment on attachment 303589 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303589&action=review > Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.h:33 > +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) I think this file should be in UIProcess/API/Cocoa?
Tim Horton
Comment 5 2017-03-06 17:22:47 PST
Comment on attachment 303589 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303589&action=review >> Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.h:33 >> +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) > > I think this file should be in UIProcess/API/Cocoa? Also, not available on Mac
Aakash Jain
Comment 6 2017-03-06 19:08:14 PST
Let's do that in a separate patch. This patch focus on fixing errors from TAPI.
Alexey Proskuryakov
Comment 7 2017-03-06 19:20:21 PST
> Also, not available on Mac That part can be fixed in this patch - I think that "macosx(NA)" would be right.
Aakash Jain
Comment 8 2017-03-06 19:26:21 PST
Yeah. I believe removing macos() and just keeping WK_CLASS_AVAILABLE(ios(8.0)) should be fine. Similar to: https://trac.webkit.org/changeset/205559/trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreviewElementInfo.h
Aakash Jain
Comment 9 2017-03-06 19:42:21 PST
Created attachment 303604 [details] Updated patch patch for landing.
WebKit Commit Bot
Comment 10 2017-03-06 20:22:57 PST
Comment on attachment 303604 [details] Updated patch Clearing flags on attachment: 303604 Committed r213495: <http://trac.webkit.org/changeset/213495>
WebKit Commit Bot
Comment 11 2017-03-06 20:23:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.